Lars Marius Garshol

Results 294 comments of Lars Marius Garshol

I managed to fix this PR, too. Please, Eliot, could you merge this one, too? This is another fix that we really need to have in Wordinator.

The fix for issue #134 was basically a fix for the same issue as this PR, but that fix was too simple. It's necessary for table cells to *end* with...

Thanks for incorporating the fix. I don't really care how it's done, as long as the problems get fixed.

Thank you for the PR! Since it doesn't build I cannot merge, unfortunately. I can't work out exactly what the problem is.

> I tend to prefer a proper review once the automated checks were successful. Yeah, sorry. I had to cook dinner, and now I have a meeting. I didn't intend...

Now it should finally be ready for review. Note that I changed the type of the `Destination.page` property. As far as I can tell it's been wrong all the time....

I think I have addressed all review comments now. Please review again.

Your review came in just as I left for holiday, so this took a while. I managed to resolve the conflicts, so I think this is ready now.

Fantastic to have this merged! Although this PR does not actually solve our problem. :) The next step is to also support link rewriting when pages have been merged.

I am fixing this in our software, outside of PyPDF now first, but I will try to make a PyPDF PR afterwards. Here is my current understanding, which will guide...