octane icon indicating copy to clipboard operation
octane copied to clipboard

Published 20 hours ago • verified publisher icon laravel

This PR fixes #562 by defining "non-standard HTTP status codes reasons" in the octane config file.

Open saderi opened this issue 3 years ago • 2 comments

This PR fixes #562 by defining "non-standard HTTP status codes reasons" in the octane config file.

This PR allows users to define other status code reasons in octane.php config file

saderi avatar Aug 08 '22 22:08 saderi

Can you add tests to this pull request please?

I can update current test if its OK, or write a new one.

saderi avatar Aug 09 '22 09:08 saderi

@nunomaduro Is this test not acceptable for this PR?

saderi avatar Aug 11 '22 06:08 saderi

I don't really love calling the global config helper from here. IMO just return a standard status and include a JSON payload providing a more detailed error code / status.

taylorotwell avatar Aug 15 '22 19:08 taylorotwell

@taylorotwell can you provide any other option to have other custom status codes (like 481) instead of using configuration file?

LordVersA avatar Apr 24 '23 10:04 LordVersA