rocket-chat icon indicating copy to clipboard operation
rocket-chat copied to clipboard

Published 20 hours ago • verified publisher icon laravel-notification-channels

Channel Launch

Open atymic opened this issue 5 years ago • 6 comments

  • [x] Code Review
  • [x] Add to website
  • [x] Create packagist package
  • [x] Travis
  • [x] Style CI
  • [x] Scrutinizer
  • [x] Add badges

atymic avatar Feb 20 '20 08:02 atymic

Website PR was merged here: https://github.com/laravel-notification-channels/website/pull/19

@antonkomarev @FunfareNico feel free to tag v1 whenever you are ready (then close this issue). Would also probably be a good idea to add a notice of depreciation to the old repo, and make the composer package as abandoned.

Thanks!

atymic avatar Feb 20 '20 23:02 atymic

I think we need to fix tests first of all, and @FunfareNico was wanted to add attachments to the package.

antonkomarev avatar Feb 21 '20 07:02 antonkomarev

@Funfare why did you released v0.1 such early? What's the rush? I'm not sure this package was ready for it. Code style is not finished. Publishing release as soon as you merging PR without any review and answering questions is not that good. I understand that package was under development for a long time, but it would be better to polish it up for a stable public releases.

If you are scary to break application with latest commits to master branch you can always freeze package on exact hash in your application.

antonkomarev avatar Feb 21 '20 21:02 antonkomarev

It will be good to switch from TravisCI to GitHub actions workflow.

antonkomarev avatar Feb 21 '20 21:02 antonkomarev

It will be good to switch from TravisCI to GitHub actions workflow.

You have admin privileges on the repo, so you should be able to set that up. Let me know if you run into any issues.

atymic avatar Feb 21 '20 22:02 atymic

@atymic could you add me to https://github.com/orgs/laravel-notification-channels/people list, please?

antonkomarev avatar Apr 26 '20 12:04 antonkomarev