channels icon indicating copy to clipboard operation
channels copied to clipboard

Add Textlocal Channel

Open msonowal opened this issue 8 years ago • 19 comments

Which provides the ability to send SMS via textlocal.in API

msonowal avatar Aug 07 '17 09:08 msonowal

Hi!

Are you still open to creating and maintaining this channel?

If so, could you update it to support laravel 5.5-6.0 please?

Thanks!

atymic avatar Sep 12 '19 01:09 atymic

@atymic Updated with laravel 6 support

msonowal avatar Sep 12 '19 07:09 msonowal

Thanks @msonowal Will get it reviewed soon :)

atymic avatar Sep 12 '19 09:09 atymic

When you have a chance could you have a look at the feedback I added please :)

atymic avatar Oct 24 '19 05:10 atymic

When you have a chance could you have a look at the feedback I added please :)

I have updated the codes with the changes requested let me know

msonowal avatar Oct 30 '19 06:10 msonowal

ping @atymic

msonowal avatar Nov 05 '19 05:11 msonowal

@msonowal Are you able to make the requested changes?

atymic avatar Dec 23 '19 21:12 atymic

@msonowal

Did you get a chance to review above?

atymic avatar Jan 18 '20 00:01 atymic

Hi @atymic Currently I am busy, I have this in mind will do when I get some time. maybe within next month

msonowal avatar Jan 20 '20 06:01 msonowal

No worries :)

atymic avatar Feb 20 '20 23:02 atymic

Hello @msonowal and @atymic When Textlocal channel will support L6/7?

Another question: how can I join to contribute like you guys are doing in this repository?

Saneesh avatar Apr 18 '20 10:04 Saneesh

Send a PR, I am really busy atm

msonowal avatar Apr 18 '20 11:04 msonowal

@atymic Hi can you check the https://github.com/msonowal/laravel-notification-channel-textlocal/tree/wip-tests-andlaravel7-support

branch wip-tests-andlaravel7-support

and also help to fix the test as I have updated the test skelton to test but not able to fix it

msonowal avatar Apr 28 '20 20:04 msonowal

Hello @msonowal and @atymic When Textlocal channel will support L6/7?

Another question: how can I join to contribute like you guys are doing in this repository?

You can use the branch wip-tests-andlaravel7-support

it has 6 and 7 support

msonowal avatar Apr 28 '20 20:04 msonowal

@msonowal

Please PR code here: https://github.com/laravel-notification-channels/textlocal

And i'll get everything set up for release :)

atymic avatar Apr 28 '20 22:04 atymic

Launch checklist https://github.com/laravel-notification-channels/textlocal/issues/1

atymic avatar Apr 28 '20 22:04 atymic

Sure thing

msonowal avatar Apr 29 '20 02:04 msonowal

Can you PR on the new repo please? Otherwise will close this and archive shortly.

atymic avatar May 18 '21 01:05 atymic

@atymic

PR https://github.com/laravel-notification-channels/textlocal/pull/3

msonowal avatar May 18 '21 07:05 msonowal