PowerModels.jl icon indicating copy to clipboard operation
PowerModels.jl copied to clipboard

Data Model Renaming

Open ccoffrin opened this issue 6 years ago • 7 comments

Revisit the names for everything in the data model and update to consistent and clean naming conventions.

@frederikgeth, this is not coming anytime soon, but we can bike shed about it in this thread.

ccoffrin avatar Dec 01 '18 20:12 ccoffrin

I would be interested in reaching some convergence between what I want to achieve in PowerSystems and PowerModels' data structure and naming.

jd-lara avatar Dec 01 '18 23:12 jd-lara

By all means. All proposals are welcome in this thread.

ccoffrin avatar Dec 01 '18 23:12 ccoffrin

We may want to start with including energy, and time symbols here, define suffixes for all entities (e.g.g for generators), map these names to the parameters and variables and define the default associated SI units?

To which degree should we attempt to future-proof the data model (e.g. angle range of phase-shifting transformers or tap range of OLTC transformers)?

frederikgeth avatar Dec 03 '18 22:12 frederikgeth

My goal would be to come up with something like a style guide for parameter names, similar to what we did for variables in https://github.com/lanl-ansi/PowerModels.jl/issues/26, then update the data model to be consistent with those conventions.

I would not be overly concerned with future-proofing. I think just covering the all the parameters we have will provide fairly robust guidelines.

ccoffrin avatar Dec 04 '18 00:12 ccoffrin

Making the convention consistent with PowerSystems/Simulations would be a great goal @claytonpbarrows

jd-lara avatar Dec 04 '18 00:12 jd-lara

@frederikgeth when we do this renaming, should we rename thermal_rating to power_rating? Seems core consistent with current_rating

ccoffrin avatar Aug 09 '19 23:08 ccoffrin

In favor of being explicit in terms of power and current for ratings instead of 'thermal'. (A thermal limit eventually should be the maximum acceptable conductor temperature.)

frederikgeth avatar Aug 12 '19 01:08 frederikgeth