langchain icon indicating copy to clipboard operation
langchain copied to clipboard

fix SQL toolkit table listing tool name

Open saswat0 opened this issue 2 years ago • 3 comments

  • Description: This PR fixes the erroneous naming convention of the list_tables_sql_db tool used for querying the list of tables present in a database. This is a minor fix which renames all the occurrences of the above tool with the one described in the tool's description.
  • Issue: Fixes #7440
  • Dependencies: None
  • Maintainer: @hinthornw

saswat0 avatar Jul 09 '23 18:07 saswat0

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2023 6:16pm

vercel[bot] avatar Jul 09 '23 18:07 vercel[bot]

@hinthornw seems spark sql tool already has this name, should we rename the spark one to indicate it's spark?

baskaryan avatar Jul 10 '23 06:07 baskaryan

@baskaryan Should there be 2 separate tools for the same job?

saswat0 avatar Jul 11 '23 03:07 saswat0

@baskaryan FYI ^

leo-gan avatar Sep 18 '23 23:09 leo-gan

Closing because the PR wouldn't line up with the current directory structure of the library (would need to be in /libs/langchain/langchain instead of /langchain). Feel free to reopen against the current head if it's still relevant!

efriis avatar Nov 07 '23 03:11 efriis