langchain icon indicating copy to clipboard operation
langchain copied to clipboard

Implement AgentExecutorIterator

Open SlapDrone opened this issue 2 years ago • 8 comments

  • Description: Implements a .iter() method for the AgentExecutor class. This allows hooking into and intercepting intermediate agent steps.
  • Issue: #6925
  • Dependencies: None
  • Tag maintainer: @vowelparrot @agola11
  • Twitter handle: @SlapDron3 @lacicocodes

SlapDrone avatar Jun 29 '23 15:06 SlapDrone

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 8:00am

vercel[bot] avatar Jun 29 '23 15:06 vercel[bot]

For any questions/feedback myself and @Lacico wrote this.

SlapDrone avatar Jun 29 '23 15:06 SlapDrone

woah, super cool. will find time to properly review but for now would be awesome to have a demo notebook (probably in docs/extras/modules/agents/how_to dir)

dev2049 avatar Jun 29 '23 19:06 dev2049

Great, good idea. Will cook a notebook up when have time on Sunday evening.

SlapDrone avatar Jun 30 '23 23:06 SlapDrone

We've added an example notebook demonstrating how to verify output generated by the agent at each step.

Lacico avatar Jul 02 '23 20:07 Lacico

Hey folks, anyone had the chance to review this? @dev2049 @vowelparrot @agola11

SlapDrone avatar Jul 04 '23 16:07 SlapDrone

Hey @hwchase17, no worries and thanks for taking a look. We were also wary of touching agent so went heavy on the tests and made only an additive change.

Had a chat with @Lacico and we are happy to hold off a bit for a full-fledged review from @baskaryan or another maintainer so we can all gain the necessary confidence that it won't break anything.

SlapDrone avatar Jul 06 '23 18:07 SlapDrone

Heya @baskaryan, do you know when/if you'll have time to give these changes a review? Thanks.

Lacico avatar Jul 09 '23 22:07 Lacico

Hey folks. Let us know if there's anything we can do to help here. If it makes a difference, we're using this in a major project so would be happy to maintain this class.

SlapDrone avatar Jul 17 '23 18:07 SlapDrone

apologies for the delay. this is awesome, thanks @SlapDrone and @Lacico!

baskaryan avatar Jul 21 '23 02:07 baskaryan