langchain icon indicating copy to clipboard operation
langchain copied to clipboard

Update web_base.py _fetch() method For SiteMapLoader

Open jackfrost1411 opened this issue 2 years ago • 1 comments

A must-include for SiteMap Loader to avoid the SSL verification error. Setting the 'verify' to False by sitemap_loader.requests_kwargs = {"verify": False} does not bypass the SSL verification in some websites.

There are websites (https:// researchadmin.asu.edu/ sitemap.xml) where setting "verify" to False as shown below would not work: sitemap_loader.requests_kwargs = {"verify": False}

We need this merge to tell the Session to use a connector with a specific argument about SSL: # For SiteMap SSL verification if not self.request_kwargs['verify']: connector = aiohttp.TCPConnector(ssl=False) else: connector = None

Fixes #5483

Before submitting

Who can review?

Tag maintainers/contributors who might be interested:

@hwchase17 @eyurtsev

jackfrost1411 avatar Jun 15 '23 21:06 jackfrost1411

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ❌ Failed (Inspect) Jun 15, 2023 9:19pm

vercel[bot] avatar Jun 15 '23 21:06 vercel[bot]

@hwchase17 is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 19 '23 00:06 vercel[bot]