langchain icon indicating copy to clipboard operation
langchain copied to clipboard

RFC: Flag to pass openai creds at invocation

Open dev2049 opened this issue 2 years ago • 1 comments

If we like this approach i'll add it to all OpenAI wrappers

dev2049 avatar Jun 02 '23 00:06 dev2049

@dev2049 This works, we'll need to figure out how to handle things for serialization.

eyurtsev avatar Jun 02 '23 01:06 eyurtsev

why dont we just always pass at invocation?

openai docs make it seem like setting global vars is proper way to do it but i don't feel strongly about that. makes serialization a bit trickier but that's something we'll have to reckon with anyways.

so mainly just didn't want to rock the boat too much (in case there was a legit reason to not pass at invocation i wasn't aware of)

dev2049 avatar Jun 04 '23 23:06 dev2049