Removes leftover embedding_function name / doc references from chroma/atlas vectorstores

[EvanOman]

Removes leftover embedding_function name / doc references from chroma/atlas vectorstores

The Chroma and Atlas vector stores had been refactored to use a Embeddings instance rather than an embedding_function.

This PR cleans up a few variable names and comments which still used the old name embedding_function but used the new Embeddings object. This should make those sections of the code more readable.

Who can review?

Anybody, but @dev2049 in particular

[dev2049]

this is a great cleanup but breaks backwards compatibility, so we'll want to think of some workaround for that

[EvanOman]

@dev2049 Are you thinking about people using the old embedding_function as a named argument?

I could check the kwargs to see if the Embeddings instance is being passed as an embedding_function argument, use it, and then print a deprecation warning

[dev2049]

sounds reasonable to me @EvanOman!

[EvanOman]

@dev2049 Done, let me know if there any other suggestions 👍

[EvanOman]

Hey @dev2049 , just pinging one more time on this, thanks! 👍

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
langchain	❌ Failed (Inspect)			Jun 23, 2023 5:28pm

[EvanOman]

Looks like the Vercel bot is not happy, I'd address the issue but I don't have any access on Vercel to see what's up

[leo-gan]

@EvanOman Hi , could you, please, resolve the merging issues? After that ping me and I push this PR for the review. Thanks! Seems, you need just commit some dummy change and Vercel would reset.

[efriis]

Closing because the PR wouldn't line up with the current directory structure of the library (would need to be in /libs/langchain/langchain instead of /langchain). Feel free to reopen against the current head if it's still relevant!