langchain icon indicating copy to clipboard operation
langchain copied to clipboard

Published 20 hours ago • verified publisher icon langchain-ai

Add _type for all parsers

Open vowelparrot opened this issue 2 years ago • 5 comments

Used for serialization. Also add test that recurses through our subclasses to check they have them implemented

Would fix https://github.com/hwchase17/langchain/issues/3217

vowelparrot avatar Apr 22 '23 00:04 vowelparrot

Hm ok. @hwchase17 do you have thoughts on a short-term fix for https://github.com/hwchase17/langchain/issues/3217 then?

vowelparrot avatar Apr 23 '23 22:04 vowelparrot

hmmm i guess we can probably merge if this is causing issues

hwchase17 avatar Apr 25 '23 04:04 hwchase17

Hey @vowelparrot, its breaking for us as well. Is this something we can get it ready for review and merge it if everything look good?

sunishsheth2009 avatar Apr 26 '23 16:04 sunishsheth2009

Hey @vowelparrot, its breaking for us as well. Is this something we can get it ready for review and merge it if everything look good?

Working on it - need to wrap up some serialization checks before landing

vowelparrot avatar Apr 27 '23 06:04 vowelparrot

Hey @vowelparrot is there something that we can help here? We are kind of blocked until this is merged, unless there is another way to solve this issue? thank you.

cc @hwchase17

sunishsheth2009 avatar May 04 '23 21:05 sunishsheth2009

landed #4189

dev2049 avatar May 19 '23 01:05 dev2049