langchain icon indicating copy to clipboard operation
langchain copied to clipboard

Published 20 hours ago • verified publisher icon langchain-ai

update Qdrant documentation

Open meal opened this issue 2 years ago • 5 comments

fix from_documents method usage for Qdrant in documentation as previous example doesn't work

meal avatar Apr 18 '23 19:04 meal

That's right! I'll update this

meal avatar Apr 19 '23 07:04 meal

Looks good to me. Changes summary:

  1. Removed prefer_grpc=True
  2. Added a note about the from_documents endpoint in Langchain — not specific to qdrant
  3. Changed url to a kwarg with url=url

NirantK avatar May 08 '23 05:05 NirantK

Why prefer_grpc has been removed?

joein avatar May 09 '23 08:05 joein

Why prefer_grpc has been removed?

also wondering 👆

dev2049 avatar May 09 '23 17:05 dev2049

Not all APIs are implemented in gRPC yet. The official qdrant README doesn't recommend this as a starting option either

from qdrant_client import QdrantClient
qdrant = QdrantClient(":memory:") # Create in-memory Qdrant instance, for testing, CI/CD
# OR
client = QdrantClient(path="path/to/db")  # Persists changes to disk, fast prototyping

In Client-Server:

qdrant = QdrantClient("http://localhost:6333") # Connect to existing Qdrant instance, for production

That said, it should be fine both ways — gRPC will indeed be faster for insert/upsert kind of operations.

NirantK avatar May 10 '23 04:05 NirantK

@meal Hi , could you, please, resolve the merging issues and address the last comments (if needed)? After that ping me and I push this PR for the review. Thanks!

leo-gan avatar Sep 13 '23 00:09 leo-gan

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 11:30pm

vercel[bot] avatar Oct 12 '23 23:10 vercel[bot]