langchain-postgres icon indicating copy to clipboard operation
langchain-postgres copied to clipboard

Published 20 hours ago • verified publisher icon langchain-ai

fix: use self.embeddings.aembed_* in async methods

Open liunux4odoo opened this issue 1 year ago • 2 comments

using sync methods of embeddings in PGVector async methods harms performance.

liunux4odoo avatar Aug 06 '24 09:08 liunux4odoo

@liunux4odoo I tested your PR branch on one of my projects, and it fixed our issue. Thanks!

This PR is needed to not break our async data pipelines - I am quite surprised this was an issue at all...

@efriis, @eyurtsev, @pprados Can some of the maintainers please review this PR?

andreped avatar Aug 20 '24 09:08 andreped

@liunux4odoo I tested your PR branch on one of my projects, and it fixed our issue. Thanks!

This PR is needed to not break our async data pipelines - I am quite surprised this was an issue at all...

@efriis, @eyurtsev, @pprados Can some of the maintainers please review this PR?

Glad to see this helps.

liunux4odoo avatar Aug 20 '24 10:08 liunux4odoo

So strange the tests failed, I cannot check what's wrong.

liunux4odoo avatar Sep 02 '24 03:09 liunux4odoo