toybox icon indicating copy to clipboard operation
toybox copied to clipboard

expr: fix memory management

Open E5ten opened this issue 6 years ago • 3 comments

Andy Chu's patch from the mailing list, modified slightly to fit the current source. http://lists.landley.net/htdig.cgi/toybox-landley.net/2016-March/008113.html

This fixes #147 as well as fixing all remaining memory management issues in expr from what I can see (valgrind now gives no warnings or any indication of issues while previously it reported many invalid reads).

E5ten avatar Oct 10 '19 18:10 E5ten

ping

E5ten avatar Nov 09 '19 03:11 E5ten

uh I did not mean to do that

E5ten avatar Nov 11 '19 16:11 E5ten

(you might want to squash the two commits into one for ease of review. you probably also want to just send the patch on the list, because rob pays more attention to that than to the pull requests...)

enh-google avatar Nov 11 '19 18:11 enh-google