lance
lance copied to clipboard
chore(api)!: remove unused param in take call
Related to https://github.com/lancedb/lance/issues/3444
Removed unused kwargs parameter in LanceDataset.take
ACTION NEEDED Lance follows the Conventional Commits specification for release automation.
The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.
For details on the error please inspect the "PR Title Check" action.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.48%. Comparing base (
f69480e) to head (1cbb199).
Additional details and impacted files
@@ Coverage Diff @@
## main #3453 +/- ##
==========================================
- Coverage 78.48% 78.48% -0.01%
==========================================
Files 252 252
Lines 93800 93800
Branches 93800 93800
==========================================
- Hits 73623 73619 -4
- Misses 17184 17186 +2
- Partials 2993 2995 +2
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 78.48% <ø> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It looks like Cargo.lock needs to be updated, go into python directory and run cargo check would update it @lyang24
the failed cases are not related to this PR, merge it. thanks for the contribution! @lyang24