lance icon indicating copy to clipboard operation
lance copied to clipboard

feat: cuda/cuvs acceleration for PQ training/assignment

Open jacketsj opened this issue 1 year ago • 2 comments

blocked by #2816

Benchmarking ongoing on wikipedia-40M early tests indicate that cuvs pq params might need some better tuning

Hardware for testing:

  • n1-standard-16
  • nvidia T4

jacketsj avatar Sep 11 '24 15:09 jacketsj

ACTION NEEDED Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

github-actions[bot] avatar Sep 11 '24 15:09 github-actions[bot]

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 78.09%. Comparing base (c0e1f15) to head (bca8c82).

Files with missing lines Patch % Lines
rust/lance/src/index/vector/ivf.rs 22.22% 5 Missing and 2 partials :warning:
rust/lance/src/index/vector/ivf/builder.rs 0.00% 3 Missing :warning:
rust/lance-index/src/vector/ivf/builder.rs 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2853      +/-   ##
==========================================
- Coverage   78.12%   78.09%   -0.04%     
==========================================
  Files         229      229              
  Lines       70492    70497       +5     
  Branches    70492    70497       +5     
==========================================
- Hits        55073    55054      -19     
- Misses      12305    12317      +12     
- Partials     3114     3126      +12     
Flag Coverage Δ
unittests 78.09% <20.00%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 11 '24 15:09 codecov-commenter

switched branch, new pr at https://github.com/lancedb/lance/pull/2946

jacketsj avatar Sep 27 '24 21:09 jacketsj