lance
lance copied to clipboard
feat: add outer retry loop to more object_store operations
I was investigating a GCS error that a user was seeing and discovered there were several places that we do not have an outer retry loop around object_store. However, I later realized that object_store was actually performing retries in the original error I was investigating. So I'm not certain these changes would be needed in a real world scenario. Curious to get a second opinion.
Codecov Report
Attention: Patch coverage is 87.83784% with 18 lines in your changes missing coverage. Please review.
Project coverage is 80.02%. Comparing base (
8746737) to head (4fadfe5).
Additional details and impacted files
@@ Coverage Diff @@
## main #2458 +/- ##
==========================================
+ Coverage 79.99% 80.02% +0.03%
==========================================
Files 207 207
Lines 58623 58715 +92
Branches 58623 58715 +92
==========================================
+ Hits 46894 46987 +93
- Misses 8970 8975 +5
+ Partials 2759 2753 -6
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 80.02% <87.83%> (+0.03%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closing for now as this isn't urgent for me and I'm still uncertain its the best approach.