lance icon indicating copy to clipboard operation
lance copied to clipboard

perf: make VectorStorage and DistCalculator static to generate better code

Open BubbleCal opened this issue 1 year ago • 2 comments

4.3647% faster

BubbleCal avatar May 20 '24 07:05 BubbleCal

blocked by #2353

BubbleCal avatar May 20 '24 07:05 BubbleCal

Codecov Report

Attention: Patch coverage is 73.17073% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 80.69%. Comparing base (21d6a25) to head (fea075a). Report is 4 commits behind head on main.

Files Patch % Lines
rust/lance-index/src/vector/hnsw/builder.rs 81.25% 0 Missing and 3 partials :warning:
rust/lance-index/src/vector/sq/storage.rs 40.00% 3 Missing :warning:
rust/lance-index/src/vector/pq/storage.rs 75.00% 1 Missing :warning:
rust/lance/src/index/vector/fixture_test.rs 0.00% 1 Missing :warning:
rust/lance/src/index/vector/ivf.rs 0.00% 1 Missing :warning:
rust/lance/src/index/vector/pq.rs 0.00% 1 Missing :warning:
rust/lance/src/session/index_extension.rs 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2355      +/-   ##
==========================================
- Coverage   80.72%   80.69%   -0.04%     
==========================================
  Files         192      191       -1     
  Lines       56230    56355     +125     
  Branches    56230    56355     +125     
==========================================
+ Hits        45394    45478      +84     
- Misses       8213     8248      +35     
- Partials     2623     2629       +6     
Flag Coverage Δ
unittests 80.69% <73.17%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 20 '24 08:05 codecov-commenter