vim-gina icon indicating copy to clipboard operation
vim-gina copied to clipboard

No spinner for :Gina push / pull

Open SamSaffron opened this issue 7 years ago • 6 comments

Hi there, I am probably doing something silly so apologies but on my default install of Gina on both vim and neovim I am not getting any spinner in my statusline for :Gina push / :Gina pull

I tried adding let g:gina#core#spinner#delaytime=1 but even with that I am not getting anything.

SamSaffron avatar May 29 '18 00:05 SamSaffron

The spinner is used to indicate that a target buffer is being loaded. So it is not shown for command which does not open a buffer.

lambdalisue avatar May 29 '18 02:05 lambdalisue

I see, can I make this a feature request, it would be nice to be able to see a spinner while git push/pull is happening, I get the message when it is done, but it would be super nice to see it is in progress.

SamSaffron avatar May 29 '18 03:05 SamSaffron

Hum... Ok, I think it's worth to consider. Could you explain your expected behavior a bit more so that I can imagine what you want more correctly?

lambdalisue avatar May 29 '18 04:05 lambdalisue

hmmmm... I think you would specify a placeholder in your status line and then Gina would update the status line N times a second until the operation is finished. Changing the placeholder / refreshing and so on.

Gina can feature detect it so you don't even need to "enable"/"disable" the feature. If it sees that you have the placeholder in statusline is will perform the updates otherwise it just works as it is today.

Eg:

set statusline+=%{GinaProgress()}

SamSaffron avatar May 29 '18 05:05 SamSaffron

Hi, @lambdalisue. I wanna help with this issue.

I see that you already have autoload/gina/core/spinner.vim file. Is it possible to use it for this purpose?

semanser avatar Mar 30 '19 21:03 semanser

Probably yes 👍

lambdalisue avatar Apr 02 '19 04:04 lambdalisue