ornament icon indicating copy to clipboard operation
ornament copied to clipboard

[WIP] bump girouette

Open oxalorg opened this issue 3 years ago • 4 comments

This PR updates griouette to v0.0.10 while still mainting backward compat

i.e. ornament will still be using Tailwind v2 bindings in girouette instead of using the updated Tailwind v3 functions.

In v0.0.8 girouette made some breaking changes. Look #18 for more info

oxalorg avatar Jul 20 '22 10:07 oxalorg

Seems we don't need much to be able to let the user opt-in to v3

  • they can already set the different tokens (fonts, colors, components)
  • the preflight can be handled outside of ornament, it's just a convenience that we include it
  • the classname function would have to become configurable, that's not the case yet

Can we make that classname function configurable? And then document in the readme what it would look like if someone wants to opt-in to v3?

plexus avatar Jul 20 '22 14:07 plexus

There is a bug (from formatting?): (:require) terminates early https://github.com/lambdaisland/ornament/blob/a0f96cdb6f74d2bf9a26117582bcf41e28ba9167/src/lambdaisland/ornament.cljc#L4

GetBitOutdoors avatar Sep 10 '22 20:09 GetBitOutdoors

Thanks @GetBitOutdoors, that should be fixed now.

plexus avatar Sep 19 '22 08:09 plexus

2022-09-19_105139_firefox-nightly

One failing test.

plexus avatar Sep 19 '22 08:09 plexus

Any chance of getting this into a release? Being able to use the current version of girouette would be nice.

daaku avatar Oct 30 '22 16:10 daaku

Released in

[com.lambdaisland/ornament "0.7.77"]
{com.lambdaisland/ornament {:mvn/version "0.7.77"}}

plexus avatar Nov 25 '22 11:11 plexus