dom-types icon indicating copy to clipboard operation
dom-types copied to clipboard

Published 20 hours ago • verified publisher icon lambdaisland

Add DOMStringMap type

Open earthfail opened this issue 2 years ago • 2 comments

I would like to add DOMStringMap type to the list. It comes up when accessing data-* attributes of an Element and would be useful for inspection. Is it okay to make a pull request?

note: I'm new to open source contributing but I read lambdaisland/open source README , CONTRIBUTING section and took an overview of the code. I think I can manage to help and maybe add section on usage for how to use the library.

earthfail avatar Sep 25 '23 16:09 earthfail

Go for it! Just open a PR, it'll likely get merged right away, or there might be a bit of feedback. We try to be fairly low process. Adding a changelog entry would be appreciated, that makes it easier to immediately put out a new release. Just put it under the top section "Unreleased". You don't need to add a version number, those get generated by the tooling.

plexus avatar Sep 26 '23 11:09 plexus

thank you @plexus for the encouragement. I made a pr #8 . In the end I didn't add to usage section because it English isn't my first language and don't want to conflict the code with documentation. but I would like to in the next time and possibly a section on testing.

I would like to hear your feedback.

earthfail avatar Sep 29 '23 00:09 earthfail