lambdaworks

lambdaworks copied to clipboard

Tasks: - [x] Implement [Starknet Crypto equivalent ](https://docs.starkware.co/starkex/crypto/pedersen-hash-function.html) implementation. Test with some values of [StarknetRS](https://github.com/xJonathanLEI/starknet-rs/blob/4ab2f36872435ce57b1d8f55856702a6a30f270a/starknet-crypto/src/pedersen_hash.rs) - [ ] Add a differential fuzzer against [StarknetRS](https://github.com/xJonathanLEI/starknet-rs/blob/4ab2f36872435ce57b1d8f55856702a6a30f270a/starknet-crypto/src/pedersen_hash.rs) - [ ] Generalize over the...

MauroToscano

Short Weierstrass point compression

1

I've noticed a [TODO](https://github.com/lambdaclass/lambdaworks/blob/main/math/src/elliptic_curve/short_weierstrass/point.rs#L237) in the codebase but couldn't find a ticket for it. I'd made a partial implementation [here](https://github.com/near/rollup-data-availability/pull/53/commits/3d3bb10c895e20a504653475e4deffd6ce26f885) but since removed it because I've only recently been diving...

carrion256

As raised in this [comment](https://github.com/lambdaclass/lambdaworks/pull/612#discussion_r1382018388), it would be great if we could validate the algorithms with intermediate results from other libraries, such as gnark. The idea would be: -> Implement...

gabrielfior

The plonk prover ([provers/plonk/src/prover.rs](https://github.com/lambdaclass/lambdaworks/blob/main/provers/plonk/src/prover.rs)) has its own implementation of the `Serializable` trait. Maybe it could be better to use the implementation of `Serializable` for `FieldElement` and make benchmarks comparing which...

mdvillagra

Currently printing a Montgomery element displays the internal bytes encoded in montgomery form. @mdvillagra mentioned it would be convenient if Display for Montgomery printed out the limbs values of the...

PatStiles

Followup on #202 from previous repo

1

Hi guys, has https://github.com/lambdaclass/lambdaworks_stark_platinum/issues/202 been addressed in the migrated code?

mcarilli

impl IsUnsignedInteger trait for u8 too

4

in `math/src/unsigned_integer/traits.rs` ```rust pub trait IsUnsignedInteger: Shr + BitAnd + Eq + Ord + From + Copy + Display + Add { } ``` The `From` part prevents the trait...

tdelabro

Implement Rescue Prime Required: - [ ] Implement Rescue Prime Permutation over the StarkField. [Algorithm 3](https://eprint.iacr.org/2020/1143.pdf). Use [Algorithm 4](https://eprint.iacr.org/2020/1143.pdf) to generate the Standard MDS Matrix. Test it with some cases...

MauroToscano

Add GCD as a standalone function

1

We are currently using the extended euclidean algorithm when calculating multiplicative inverses. We could also add the computation of the greatest common divisor as a standalone function.

dbejarano820

`to_affine()` should return a result instead of panicking when z is 0

7

`to_affine()` should return a result instead of panicking when z is 0

MauroToscano