lambdaworks icon indicating copy to clipboard operation
lambdaworks copied to clipboard

feat(backend): Add Icicle as a GPU backend

Open PatStiles opened this issue 1 year ago • 2 comments
trafficstars

Add Icicle as a GPU backend

Description

This pr adds wrappers for conversion of lambaworks types -> Icicle types and adds methods to interface with the Icicle GPU backend. Upstreaming this conversion into the Icicle repo would remove much of the boilerplate. Closes #353

Type of change

  • [x] New feature

Checklist

  • [x] Linked to Github Issue
  • [ ] Unit tests added
  • [ ] This change requires new documentation.
    • [ ] Documentation has been added/updated.
  • [ ] This change is an Optimization
    • [ ] Benchmarks added/run

PatStiles avatar Feb 05 '24 02:02 PatStiles

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.55%. Comparing base (601ab67) to head (8e898ad).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #800   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files         154      154           
  Lines       34587    34587           
=======================================
  Hits        32705    32705           
  Misses       1882     1882           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 21 '24 17:02 codecov-commenter

For some reason it's not compiling locally.

failed to select a version for rayon. ... required by package icicle-core v1.4.0 (https://github.com/ingonyama-zk/icicle.git?tag=v1.4.0#15a63cc5) ... which satisfies git dependency icicle-core of package lambdaworks-math v0.5.0 (/Users/maurofab/workspace/lambdaworks/math) ... which satisfies path dependency lambdaworks-math (locked to 0.5.0) of package arkworks_adapter v0.5.0 (/Users/maurofab/workspace/lambdaworks/provers/groth16/arkworks-adapter) versions that meet the requirements ^1.8.1 are: 1.9.0, 1.8.1

I'll investigate this a bit

MauroToscano avatar Mar 06 '24 21:03 MauroToscano