concrete icon indicating copy to clipboard operation
concrete copied to clipboard

Validate that `self` must be the first parameter in impl method

Open dsocolobsky opened this issue 4 months ago • 3 comments

image

I think this solves #216 ? Let me know if I need to change anything.

dsocolobsky avatar Jul 20 '25 19:07 dsocolobsky

Benchmarking (macOS) factorial

Compiling factorial (factorial.con) Finished release in 1.871051667s Running 5000000 iterations Using input value: 20 Concrete Result = 2432902008176640000 Time taken : 39.05 ms Rust Result = 2432902008176640000 Time taken : 33.91 ms

Benchmarking (macOS) fib

Compiling fib (fib.con) Finished release in 168.960291ms Running 5000 iterations Using input value: 20 Concrete Result = 6765 Time taken : 100.83 ms Rust Result = 6765 Time taken : 109.89 ms

github-actions[bot] avatar Jul 20 '25 19:07 github-actions[bot]

Benchmarking (Linux) factorial

Compiling factorial (factorial.con) Finished release in 32.892612ms Running 5000000 iterations Using input value: 20 Concrete Result = 2432902008176640000 Time taken : 96.89 ms Rust Result = 2432902008176640000 Time taken : 60.43 ms

Benchmarking (Linux) fib

Compiling fib (fib.con) Finished release in 26.116232ms Running 5000 iterations Using input value: 20 Concrete Result = 6765 Time taken : 136.93 ms Rust Result = 6765 Time taken : 85.86 ms

github-actions[bot] avatar Jul 20 '25 19:07 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 56.16%. Comparing base (4802a28) to head (73fbbae).

Files with missing lines Patch % Lines
src/check/mod.rs 0.00% 12 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   56.29%   56.16%   -0.13%     
==========================================
  Files          25       25              
  Lines        5516     5528      +12     
==========================================
  Hits         3105     3105              
- Misses       2411     2423      +12     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jul 20 '25 19:07 codecov-commenter