cairo_native icon indicating copy to clipboard operation
cairo_native copied to clipboard

add `matches_type` for array in arg mapper and tests

Open tcoratger opened this issue 1 year ago • 2 comments
trafficstars

Checklist

  • [ ] Linked to Github Issue
  • [ ] Unit tests added
  • [ ] Integration tests added.
  • [ ] This change requires new documentation.
    • [ ] Documentation has been added/updated.

tcoratger avatar Jun 25 '24 21:06 tcoratger

Codecov Report

Attention: Patch coverage is 99.30233% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.55%. Comparing base (354ef2b) to head (b19f170).

Files with missing lines Patch % Lines
src/values.rs 99.23% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
+ Coverage   88.42%   88.55%   +0.13%     
==========================================
  Files         120      120              
  Lines       35467    35897     +430     
==========================================
+ Hits        31362    31789     +427     
- Misses       4105     4108       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 25 '24 22:06 codecov-commenter

@igaray is there anything missing here?

tcoratger avatar Jul 23 '24 17:07 tcoratger

@azteca1998 Just fixed the conflicts, let me know if we can merge

tcoratger avatar Aug 29 '24 13:08 tcoratger

The code for jit values changed quite a bit and it has got some tests, closing as this is outdated.

edg-l avatar Oct 02 '24 09:10 edg-l