cairo_native icon indicating copy to clipboard operation
cairo_native copied to clipboard

Fix the starknet libfuncs' bugs.

Open azteca1998 opened this issue 1 year ago • 2 comments
trafficstars

Basically porting the Starknet libfuncs to use the blockext since the bug was fixed in a separate PR.

Checklist

  • [ ] Linked to Github Issue
  • [ ] Unit tests added
  • [ ] Integration tests added.
  • [ ] This change requires new documentation.
    • [ ] Documentation has been added/updated.

azteca1998 avatar Jun 20 '24 17:06 azteca1998

Benchmark results Main vs HEAD

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.212 ± 0.019 3.189 3.245 1.00 ± 0.01
base factorial_2M.cairo (JIT) 3.208 ± 0.012 3.187 3.227 1.00
head factorial_2M.cairo (AOT) 3.265 ± 0.039 3.222 3.341 1.02 ± 0.01
base factorial_2M.cairo (AOT) 3.336 ± 0.043 3.237 3.389 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.866 ± 0.034 2.789 2.896 1.00 ± 0.02
base fib_2M.cairo (JIT) 2.865 ± 0.034 2.820 2.918 1.00
head fib_2M.cairo (AOT) 2.888 ± 0.029 2.824 2.923 1.01 ± 0.02
base fib_2M.cairo (AOT) 2.978 ± 0.056 2.839 3.031 1.04 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 3.417 ± 0.089 3.294 3.542 1.09 ± 0.03
base logistic_map.cairo (JIT) 3.413 ± 0.037 3.349 3.462 1.09 ± 0.02
head logistic_map.cairo (AOT) 3.134 ± 0.050 3.043 3.205 1.00
base logistic_map.cairo (AOT) 3.142 ± 0.047 3.075 3.213 1.00 ± 0.02

github-actions[bot] avatar Jun 20 '24 17:06 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.17%. Comparing base (7faf271) to head (8ab4f21).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #694      +/-   ##
==========================================
- Coverage   88.70%   88.17%   -0.54%     
==========================================
  Files         121      121              
  Lines       35563    34575     -988     
==========================================
- Hits        31546    30485    -1061     
- Misses       4017     4090      +73     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 21 '24 15:06 codecov-commenter