cairo_native
cairo_native copied to clipboard
Refactor `sint8` to use `BlockExt` trait
trafficstars
Checklist
- [ ] Linked to Github Issue
- [ ] Unit tests added
- [ ] Integration tests added.
- [ ] This change requires new documentation.
- [ ] Documentation has been added/updated.
Thanks for you contribution!
Looks like clippy is complaining, looks good otherwise.
Ready for review now @igaray @edg-l
Codecov Report
Attention: Patch coverage is 98.71795% with 1 line in your changes missing coverage. Please review.
Project coverage is 91.79%. Comparing base (
eacacf7) to head (e0563dd).
| Files | Patch % | Lines |
|---|---|---|
| src/libfuncs/sint8.rs | 98.71% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #637 +/- ##
==========================================
- Coverage 91.82% 91.79% -0.04%
==========================================
Files 115 115
Lines 34254 34126 -128
==========================================
- Hits 31455 31326 -129
- Misses 2799 2800 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
has conflicts
Closing as the author hasnt fixed the conflicts