cairo_native icon indicating copy to clipboard operation
cairo_native copied to clipboard

Refactor `sint8` to use `BlockExt` trait

Open RajeshRk18 opened this issue 1 year ago • 4 comments
trafficstars

Checklist

  • [ ] Linked to Github Issue
  • [ ] Unit tests added
  • [ ] Integration tests added.
  • [ ] This change requires new documentation.
    • [ ] Documentation has been added/updated.

RajeshRk18 avatar May 31 '24 11:05 RajeshRk18

Thanks for you contribution!

Looks like clippy is complaining, looks good otherwise.

edg-l avatar May 31 '24 11:05 edg-l

Ready for review now @igaray @edg-l

RajeshRk18 avatar Jun 05 '24 00:06 RajeshRk18

Codecov Report

Attention: Patch coverage is 98.71795% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.79%. Comparing base (eacacf7) to head (e0563dd).

Files Patch % Lines
src/libfuncs/sint8.rs 98.71% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
- Coverage   91.82%   91.79%   -0.04%     
==========================================
  Files         115      115              
  Lines       34254    34126     -128     
==========================================
- Hits        31455    31326     -129     
- Misses       2799     2800       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 05 '24 18:06 codecov-commenter

has conflicts

edg-l avatar Jun 18 '24 12:06 edg-l

Closing as the author hasnt fixed the conflicts

edg-l avatar Sep 13 '24 10:09 edg-l