cairo_native icon indicating copy to clipboard operation
cairo_native copied to clipboard

Review TODO comments

Open hakymulla opened this issue 6 months ago • 1 comments

Review TODO comments #1190

Checklist

  • [x] Linked to Github Issue
  • [ ] Unit tests added
  • [ ] Integration tests added.
  • [ ] This change requires new documentation.
    • [ ] Documentation has been added/updated.

hakymulla avatar May 10 '25 10:05 hakymulla

Hey @hakymulla, could you update the links to not include the trailing #issue-....?

As an example:

  • instead of: https://github.com/lambdaclass/cairo_native/issues/1216#issue-3052795891
  • Use: https://github.com/lambdaclass/cairo_native/issues/1216

JulianGCalderon avatar May 15 '25 18:05 JulianGCalderon

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.18%. Comparing base (789c84e) to head (785462c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1227   +/-   ##
=======================================
  Coverage   80.18%   80.18%           
=======================================
  Files         112      112           
  Lines       29980    29979    -1     
=======================================
  Hits        24040    24040           
+ Misses       5940     5939    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar May 30 '25 14:05 codecov-commenter

CI is failing because code is not formatted, Could you fix these errors? Thanks!

gabrielbosio avatar May 30 '25 21:05 gabrielbosio

I resigned all commits so that we can merge it.

JulianGCalderon avatar Jun 11 '25 18:06 JulianGCalderon

There are failing CI jobs because this PR is an external contribution. However we can merge this PR safely because it only changes documentation, not code.

gabrielbosio avatar Jun 12 '25 21:06 gabrielbosio