cairo-vm icon indicating copy to clipboard operation
cairo-vm copied to clipboard

Install deps should use pip3?

Open unbalancedparentheses opened this issue 3 years ago • 3 comments

I am pretty sure the make deps is not working... we should be using pip3. Please correct me if I'm wrong https://github.com/lambdaclass/cleopatra_cairo/blob/main/Makefile#L45-L48

unbalancedparentheses avatar Jul 23 '22 12:07 unbalancedparentheses

pip3 is a disambiguation in case both Python 2.7 and Python 3.x coexist, but pip is not necessarily for 2.7. With pyenv, pip is the one matching the pyenv currently active:

[pelito@pelito-x1 cleopatra_cairo]$ PYENV_VERSION=3.7.12 pip -V
pip 20.1.1 from /home/pelito/.pyenv/versions/3.7.12/lib/python3.7/site-packages/pip (python 3.7)

Oppen avatar Jul 23 '22 18:07 Oppen

Mmm on my machine I got a "can't find pip" when running make deps. I will try to replicate it.

unbalancedparentheses avatar Jul 25 '22 08:07 unbalancedparentheses

Is it a Debian derivative? Is it using pyenv or calling pip directly? Debian derivatives still ship Python 2.7 AFAIK and you need to install a package called something like python-is-python3 for python and pip to point to version 3.x.

Oppen avatar Jul 25 '22 14:07 Oppen

we use pyenv

pefontana avatar Jun 14 '23 20:06 pefontana