cairo-vm icon indicating copy to clipboard operation
cairo-vm copied to clipboard

Remove unused error variants

Open fmoletta opened this issue 1 year ago • 4 comments

fmoletta avatar May 10 '24 15:05 fmoletta

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     22.709 s ±  0.008 s    [User: 21.820 s, System: 0.886 s]
  Range (min … max):   22.704 s … 22.715 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     22.774 s ±  0.022 s    [User: 21.909 s, System: 0.861 s]
  Range (min … max):   22.758 s … 22.789 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     12.265 s ±  0.020 s    [User: 22.070 s, System: 0.870 s]
  Range (min … max):   12.251 s … 12.279 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     12.361 s ±  0.133 s    [User: 22.192 s, System: 0.876 s]
  Range (min … max):   12.267 s … 12.455 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.01 ± 0.01 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):      9.563 s ±  0.330 s    [User: 34.454 s, System: 1.062 s]
  Range (min … max):    9.330 s …  9.797 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):      9.507 s ±  0.083 s    [User: 34.237 s, System: 1.047 s]
  Range (min … max):    9.448 s …  9.566 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.01 ± 0.04 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):      9.406 s ±  0.031 s    [User: 34.415 s, System: 1.082 s]
  Range (min … max):    9.384 s …  9.428 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):      9.979 s ±  0.031 s    [User: 34.189 s, System: 1.081 s]
  Range (min … max):    9.958 s … 10.001 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.06 ± 0.00 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):      9.519 s ±  0.015 s    [User: 34.703 s, System: 1.097 s]
  Range (min … max):    9.508 s …  9.529 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):      9.397 s ±  0.103 s    [User: 34.972 s, System: 1.122 s]
  Range (min … max):    9.324 s …  9.471 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.01 ± 0.01 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):      9.654 s ±  0.166 s    [User: 34.858 s, System: 1.149 s]
  Range (min … max):    9.536 s …  9.771 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):      9.683 s ±  0.033 s    [User: 34.824 s, System: 1.190 s]
  Range (min … max):    9.659 s …  9.706 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.00 ± 0.02 times faster than hyper_threading_pr threads: 16


github-actions[bot] avatar May 10 '24 15:05 github-actions[bot]

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     27.554 s ±  0.051 s    [User: 26.755 s, System: 0.798 s]
  Range (min … max):   27.518 s … 27.590 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     27.357 s ±  0.489 s    [User: 26.541 s, System: 0.813 s]
  Range (min … max):   27.011 s … 27.703 s    2 runs
 
Summary
  'hyper_threading_pr threads: 1' ran
    1.01 ± 0.02 times faster than 'hyper_threading_main threads: 1'




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.808 s ±  0.009 s    [User: 26.988 s, System: 0.826 s]
  Range (min … max):   14.802 s … 14.814 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.539 s ±  0.063 s    [User: 26.845 s, System: 0.760 s]
  Range (min … max):   14.494 s … 14.584 s    2 runs
 
Summary
  'hyper_threading_pr threads: 2' ran
    1.02 ± 0.00 times faster than 'hyper_threading_main threads: 2'




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     11.075 s ±  0.395 s    [User: 39.134 s, System: 0.956 s]
  Range (min … max):   10.796 s … 11.355 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     11.368 s ±  0.029 s    [User: 38.572 s, System: 0.946 s]
  Range (min … max):   11.347 s … 11.388 s    2 runs
 
Summary
  'hyper_threading_main threads: 4' ran
    1.03 ± 0.04 times faster than 'hyper_threading_pr threads: 4'




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.879 s ±  0.043 s    [User: 39.318 s, System: 1.016 s]
  Range (min … max):   10.848 s … 10.909 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.752 s ±  0.173 s    [User: 38.509 s, System: 0.988 s]
  Range (min … max):   10.630 s … 10.874 s    2 runs
 
Summary
  'hyper_threading_pr threads: 6' ran
    1.01 ± 0.02 times faster than 'hyper_threading_main threads: 6'




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.918 s ±  0.005 s    [User: 39.774 s, System: 0.999 s]
  Range (min … max):   10.915 s … 10.922 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.411 s ±  0.092 s    [User: 39.141 s, System: 1.071 s]
  Range (min … max):   10.346 s … 10.476 s    2 runs
 
Summary
  'hyper_threading_pr threads: 8' ran
    1.05 ± 0.01 times faster than 'hyper_threading_main threads: 8'




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.958 s ±  0.041 s    [User: 39.849 s, System: 1.066 s]
  Range (min … max):   10.929 s … 10.987 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.547 s ±  0.203 s    [User: 39.376 s, System: 1.111 s]
  Range (min … max):   10.403 s … 10.690 s    2 runs
 
Summary
  'hyper_threading_pr threads: 16' ran
    1.04 ± 0.02 times faster than 'hyper_threading_main threads: 16'


github-actions[bot] avatar May 10 '24 15:05 github-actions[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 95.98%. Comparing base (9cedff9) to head (8802b86). :warning: Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1760   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files         104      104           
  Lines       36794    36794           
=======================================
  Hits        35315    35315           
  Misses       1479     1479           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 10 '24 15:05 codecov[bot]

Benchmark Results for unmodified programs :rocket:

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 1.932 ± 0.013 1.922 1.965 1.00
head big_factorial 1.973 ± 0.018 1.954 2.010 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 1.878 ± 0.015 1.863 1.909 1.00
head big_fibonacci 1.898 ± 0.020 1.876 1.942 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 6.626 ± 0.058 6.551 6.718 1.00
head blake2s_integration_benchmark 6.749 ± 0.129 6.649 7.054 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.006 ± 0.012 1.992 2.022 1.00
head compare_arrays_200000 2.030 ± 0.010 2.015 2.050 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.328 ± 0.008 1.312 1.341 1.00
head dict_integration_benchmark 1.351 ± 0.005 1.341 1.360 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.125 ± 0.006 1.116 1.132 1.00
head field_arithmetic_get_square_benchmark 1.142 ± 0.021 1.120 1.189 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 6.739 ± 0.052 6.641 6.797 1.00
head integration_builtins 6.871 ± 0.098 6.750 7.013 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 6.727 ± 0.055 6.659 6.800 1.00
head keccak_integration_benchmark 6.860 ± 0.083 6.762 7.003 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 1.991 ± 0.015 1.969 2.017 1.00
head linear_search 2.024 ± 0.024 2.000 2.077 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.425 ± 0.007 1.417 1.436 1.00
head math_cmp_and_pow_integration_benchmark 1.444 ± 0.005 1.434 1.449 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.364 ± 0.009 1.354 1.377 1.00
head math_integration_benchmark 1.390 ± 0.010 1.376 1.411 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.130 ± 0.005 1.124 1.135 1.00
head memory_integration_benchmark 1.147 ± 0.010 1.136 1.170 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.453 ± 0.014 1.437 1.485 1.00
head operations_with_data_structures_benchmarks 1.480 ± 0.020 1.462 1.522 1.02 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 505.3 ± 3.1 501.1 511.2 1.00
head pedersen 508.9 ± 2.4 505.4 512.1 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 592.4 ± 6.6 584.5 606.2 1.00
head poseidon_integration_benchmark 596.5 ± 5.0 590.9 605.4 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.721 ± 0.016 1.700 1.745 1.00
head secp_integration_benchmark 1.729 ± 0.014 1.717 1.758 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 612.3 ± 13.4 604.5 650.0 1.00
head set_integration_benchmark 661.5 ± 2.2 658.7 664.1 1.08 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 3.843 ± 0.072 3.778 4.029 1.00
head uint256_integration_benchmark 3.872 ± 0.039 3.838 3.954 1.01 ± 0.02

github-actions[bot] avatar May 10 '24 15:05 github-actions[bot]