cairo-vm icon indicating copy to clipboard operation
cairo-vm copied to clipboard

Use `Program::from_file` in hyperthreading crate

Open fmoletta opened this issue 1 year ago • 2 comments

The fresh run daily workflow is currently failing as compiling the hyperthreading crate requires bench files to be compiled due to the usage of include_bytes macro. As the hyperthreading crate doesn't need to be no-std, we can just read the programs from their paths. Closes #1684 & Closes #1683

fmoletta avatar Mar 21 '24 13:03 fmoletta

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.64%. Comparing base (bf7d707) to head (feebfba).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1685   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files          95       95           
  Lines       38375    38375           
=======================================
  Hits        37087    37087           
  Misses       1288     1288           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 21 '24 14:03 codecov[bot]

Benchmark Results for unmodified programs :rocket:

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.239 ± 0.011 2.219 2.262 1.00
head big_factorial 2.264 ± 0.034 2.232 2.330 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.267 ± 0.027 2.226 2.329 1.00
head big_fibonacci 2.278 ± 0.033 2.241 2.360 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.537 ± 0.132 8.257 8.671 1.00 ± 0.04
head blake2s_integration_benchmark 8.516 ± 0.298 8.302 9.279 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.340 ± 0.032 2.309 2.418 1.00
head compare_arrays_200000 2.343 ± 0.027 2.294 2.397 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.452 ± 0.018 1.431 1.494 1.00
head dict_integration_benchmark 1.476 ± 0.035 1.445 1.571 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.322 ± 0.032 1.301 1.408 1.00 ± 0.03
head field_arithmetic_get_square_benchmark 1.320 ± 0.020 1.295 1.360 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.453 ± 0.123 8.328 8.632 1.00
head integration_builtins 8.630 ± 0.339 8.364 9.515 1.02 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.863 ± 0.338 8.524 9.743 1.02 ± 0.04
head keccak_integration_benchmark 8.725 ± 0.150 8.521 8.860 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.344 ± 0.049 2.311 2.477 1.00
head linear_search 2.353 ± 0.024 2.329 2.402 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.569 ± 0.012 1.560 1.598 1.00
head math_cmp_and_pow_integration_benchmark 1.582 ± 0.017 1.565 1.618 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.429 ± 0.014 1.409 1.448 1.00
head math_integration_benchmark 1.430 ± 0.009 1.416 1.444 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.264 ± 0.010 1.253 1.287 1.00
head memory_integration_benchmark 1.275 ± 0.011 1.260 1.291 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.618 ± 0.015 1.601 1.650 1.00 ± 0.01
head operations_with_data_structures_benchmarks 1.616 ± 0.013 1.605 1.648 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 594.0 ± 2.2 590.9 597.3 1.00
head pedersen 598.7 ± 2.1 595.8 601.5 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 993.5 ± 9.5 983.3 1017.3 1.00
head poseidon_integration_benchmark 1002.5 ± 7.6 989.5 1012.1 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.879 ± 0.025 1.857 1.928 1.01 ± 0.01
head secp_integration_benchmark 1.865 ± 0.007 1.858 1.878 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 746.3 ± 5.0 742.0 757.5 1.00 ± 0.01
head set_integration_benchmark 744.6 ± 2.8 740.9 749.5 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.728 ± 0.162 4.578 5.020 1.02 ± 0.04
head uint256_integration_benchmark 4.641 ± 0.051 4.580 4.752 1.00

github-actions[bot] avatar Mar 21 '24 14:03 github-actions[bot]