cairo-vm icon indicating copy to clipboard operation
cairo-vm copied to clipboard

Remove `CairoRunner::add_additional_hash_builtin` & `VirtualMachine::disable_trace`

Open fmoletta opened this issue 1 year ago • 2 comments

Removes methods that were needed to make cairo-rs-py compatible with cairo-lang and are no longer needed

fmoletta avatar Mar 11 '24 18:03 fmoletta

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.56%. Comparing base (1725f0c) to head (a974293).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1658      +/-   ##
==========================================
- Coverage   96.56%   96.56%   -0.01%     
==========================================
  Files          95       95              
  Lines       38422    38380      -42     
==========================================
- Hits        37103    37062      -41     
+ Misses       1319     1318       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 11 '24 18:03 codecov[bot]

Benchmark Results for unmodified programs :rocket:

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.325 ± 0.045 2.295 2.448 1.00
head big_factorial 2.347 ± 0.012 2.328 2.362 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.357 ± 0.069 2.318 2.544 1.00
head big_fibonacci 2.360 ± 0.014 2.342 2.384 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.563 ± 0.180 8.368 8.839 1.00
head blake2s_integration_benchmark 8.631 ± 0.177 8.446 8.829 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.387 ± 0.017 2.363 2.429 1.00
head compare_arrays_200000 2.458 ± 0.027 2.417 2.494 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.494 ± 0.010 1.484 1.517 1.00
head dict_integration_benchmark 1.504 ± 0.007 1.495 1.515 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.333 ± 0.021 1.305 1.379 1.00 ± 0.02
head field_arithmetic_get_square_benchmark 1.327 ± 0.011 1.316 1.350 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.519 ± 0.143 8.382 8.709 1.00
head integration_builtins 8.625 ± 0.140 8.432 8.778 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.783 ± 0.149 8.663 9.051 1.00
head keccak_integration_benchmark 8.844 ± 0.142 8.701 9.033 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.400 ± 0.010 2.387 2.423 1.00
head linear_search 2.497 ± 0.054 2.450 2.591 1.04 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.612 ± 0.013 1.600 1.633 1.00
head math_cmp_and_pow_integration_benchmark 1.656 ± 0.008 1.642 1.665 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.457 ± 0.013 1.443 1.480 1.00
head math_integration_benchmark 1.491 ± 0.008 1.478 1.502 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.306 ± 0.043 1.278 1.424 1.00
head memory_integration_benchmark 1.338 ± 0.009 1.324 1.349 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.642 ± 0.010 1.633 1.669 1.00
head operations_with_data_structures_benchmarks 1.675 ± 0.012 1.664 1.702 1.02 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 596.8 ± 2.0 594.0 601.2 1.00
head pedersen 609.8 ± 9.3 603.2 632.2 1.02 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 990.4 ± 7.1 981.1 999.4 1.00
head poseidon_integration_benchmark 1001.9 ± 11.5 994.8 1033.6 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.898 ± 0.023 1.880 1.942 1.00
head secp_integration_benchmark 1.904 ± 0.012 1.892 1.923 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 733.6 ± 7.7 728.3 748.2 1.00
head set_integration_benchmark 744.7 ± 5.2 738.2 757.8 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.768 ± 0.159 4.647 5.124 1.00
head uint256_integration_benchmark 4.783 ± 0.046 4.717 4.848 1.00 ± 0.03

github-actions[bot] avatar Mar 11 '24 18:03 github-actions[bot]