cairo-vm icon indicating copy to clipboard operation
cairo-vm copied to clipboard

Feature: make test_utils macros public

Open odesenfans opened this issue 1 year ago • 1 comments

This PR makes all macros in the test_utils module public to allow for easier testing of hints (and other features) living in other crates/repositories.

Fixes #1595.

Checklist

  • [x] Linked to Github Issue
  • [ ] Unit tests added
  • [ ] Integration tests added.
  • [ ] This change requires new documentation.
    • [ ] Documentation has been added/updated.
    • [x] CHANGELOG has been updated.

odesenfans avatar Feb 05 '24 13:02 odesenfans

This PR should be mergeable. Most of the macros need to be public as they are used in public macros. I addressed all the comments that could be.

odesenfans avatar Feb 21 '24 23:02 odesenfans

Hello! Making these macros public in the current state involves making a lot of fields internal to the VM public which is not desirable at all. I think we should address this task in a different way. What these macros currently do can be implemented using the vm's public api, so we should re-implement or implement new macros that use the public api instead.

fmoletta avatar Apr 08 '24 15:04 fmoletta

Ok @fmoletta then let's close this PR, no worries.

odesenfans avatar Apr 10 '24 14:04 odesenfans