maud icon indicating copy to clipboard operation
maud copied to clipboard

Make nested `html!` invocations lazy

Open mattfbacon opened this issue 2 years ago • 4 comments

Related to #373.

For patterns like this:

fn body() -> Markup { ... }

html! {
  h1 { "My page" }
  main { (body()) }
}

There is technically no need for the intermediate buffer from body, because the markup could render directly into the outer buffer.

In my ideal API, Markup would just implement Render (the render method would have to return something other than Markup, probably just PreEscaped<String>) and take advantage of the existing render_to method.

mattfbacon avatar Jun 05 '23 20:06 mattfbacon

In my project (using #373) I solved it like this:

/// Helper for writing nested html_to!
/// Basically a lazy html! that can be rendered(-to) on demand
macro_rules! html_in {
    ($($tt:tt)*) => {
        MaudFnWrapper(|buf: &mut String| maud::html_to!{ buf, $($tt)* })
    };
}

/// A bit of closure magic to work around nested html_to!
struct MaudFnWrapper<F>(F);
impl<F> Render for MaudFnWrapper<F> 
where F: Fn(&mut String) {
    fn render_to(&self, buffer: &mut String) {
        self.0(buffer)
    }
}

Howerer this is mainly a workaround, than proper solution.

nikvoid avatar Jul 17 '23 11:07 nikvoid

Cool! I'll take a look at that and maybe make a PoC of my idea.

mattfbacon avatar Jul 17 '23 16:07 mattfbacon