maud icon indicating copy to clipboard operation
maud copied to clipboard

escape.rs symlink broken on Windows

Open lunabunn opened this issue 3 years ago • 4 comments

Current main is broken on Windows due to maud_macros/src/escape.rs being a symlink, which is broken on Windows.

The obvious fix would be to copy-and-paste the contents over, but perhaps there's a better solution?

lunabunn avatar May 12 '22 00:05 lunabunn

Oh, that's unfortunate.

I originally added that symlink to avoid duplicating the file. I thought it was an improvement over the previous approach, which was to publish a separate helper crate that was a dependency of both.

What do other libraries do instead?

lambda-fairy avatar May 23 '22 10:05 lambda-fairy

Oh, that's unfortunate.

I originally added that symlink to avoid duplicating the file. I thought it was an improvement over the previous approach, which was to publish a separate helper crate that was a dependency of both.

What do other libraries do instead?

Could we just have escape.rs live in maud_macros as a pub mod (or be reexported), and then use that from maud?

lunabunn avatar May 24 '22 15:05 lunabunn

IIRC, proc macro crates can only export macros, not normal functions.

lambda-fairy avatar May 25 '22 04:05 lambda-fairy

This is broken on NixOS too when building in the nix store.

Xe avatar Jul 10 '22 14:07 Xe

Looks like the symlink approach has too many downsides. I'll just duplicate it then 😿

lambda-fairy avatar Sep 18 '22 12:09 lambda-fairy