Lalit Kumar Bhasin

Results 425 comments of Lalit Kumar Bhasin
trafficstars

Ah please ignore - the telemetry.sdk.version is 1.13.0 in my output above, seems somehow old sdk is getting used for me. Let me check further.

@CDFriend This looks to be a good addition. when you have time, can you please make it ready for review :)

@iCodeWoods - Is this crash happening during shutdown. If yes, please refer to use-after-free document in the docs folder for proper shutdown of SDK.

@iCodeWoods [LoghManager::FlushAndTearDown](https://github.com/microsoft/cpp_client_telemetry/blob/e8a4ac8e1c64d1d2016143a0c24cabae4b3220e6/lib/api/LogManagerImpl.cpp#L365) would called PauseActivity and WaitPause. Can you ensure calling LogManager::Flush() followed by LogManager::FlushAndTearDown() before shutdown? And yes, any logs after calling FlushAndTearDown would be lost.

> But even if it is fixed, I would suggest that the SDK should fix this itself rather than letting users fix it themselves Yes, agree. This is what the...

@iCodeWoods - Would like to close this issue for incorrect usage of the SDK - not calling LogManager::FlushAndTeardown() before app shutdown. In pre-v4 era, this method needs to be called,...

This conversion operator is supposed to be used only within the SDK, for the purpose of span-filtering, and not in application. Just curious, how are you using it?

Ok, I can see what you are trying to achieve. I don't think it would be easy to achieve filtering with otel-cpp. There have been some discussions here - https://github.com/open-telemetry/opentelemetry-cpp/issues/2108#issuecomment-1517294573...

There was some attempt made to fix this as part of #1330, if someone wants to have a look further. Otherwise, I will get back to this issue shortly. The...