gh-actions-http-status icon indicating copy to clipboard operation
gh-actions-http-status copied to clipboard

test succeeds even when config cannot be read properly

Open gosuto-inzasheru opened this issue 1 year ago • 1 comments
trafficstars

why the config is not read properly i havent found out yet, but either way i think the situation below should not result in a successful test

either the parse error should raise completely, or an empty array should not result in a success?

==Starting gh-actions HTTP Status==

jq: parse error: Expected another array element at line 1, column 120

HTTP Status result: Success

==END==

gosuto-inzasheru avatar Jan 10 '24 13:01 gosuto-inzasheru

i think what happened in this case is that the steps.deploy.outputs.url var did not exist..

      - name: Confirm deployed HTTP status code
        uses: "lakuapik/gh-actions-http-status@v1"
        with:
          sites: '["${{ steps.deploy.outputs.url }}"]'
          expected: "[200]"

gosuto-inzasheru avatar Jan 10 '24 13:01 gosuto-inzasheru