google_benchmark_plot icon indicating copy to clipboard operation
google_benchmark_plot copied to clipboard

Published 20 hours ago • verified publisher icon lakshayg

support BENCHMARK_CAPTURE macro

Open dvirtz opened this issue 6 years ago • 2 comments

Using the BENCHMARK_CAPTURE macro adds another level to the benchmark name so the results show as function/benchmark_name/input_size which interfere with the parsing.

This PR fixes this issue in a backward compatible manner.

dvirtz avatar Sep 20 '19 03:09 dvirtz

Hey there, thanks for the PR. I have been planning to add some unit tests to this code for a while now. I think it would be a good idea to not merge this PR until I add them. Once the tests are in place, I'll be happy to merge this PR

lakshayg avatar Sep 26 '19 05:09 lakshayg

Sounds good to me.

On Thu, Sep 26, 2019, 08:39 Lakshay Garg [email protected] wrote:

Hey there, thanks for the PR. I have been planning to add some unit tests to this code for a while now. I think it would be a good idea to not merge this PR until I add them. Once the tests are in place, I'll be happy to merge this PR

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lakshayg/google_benchmark_plot/pull/3?email_source=notifications&email_token=AB2ORDICXT6Y6V65DAOU3V3QLRDJFA5CNFSM4IYSIRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7ULSFY#issuecomment-535345431, or mute the thread https://github.com/notifications/unsubscribe-auth/AB2ORDNPZ4ATBVKRTUU22ALQLRDJFANCNFSM4IYSIRBQ .

dvirtz avatar Sep 26 '19 06:09 dvirtz