nextjs-notion-waitlist-template icon indicating copy to clipboard operation
nextjs-notion-waitlist-template copied to clipboard

Notion API response fix

Open nandanams03 opened this issue 1 year ago • 2 comments

My first open source contribution. ✨

Changed the Notion post API response's structure and types.

nandanams03 avatar Oct 10 '24 17:10 nandanams03

@nandanams03 is attempting to deploy a commit to the Lakssh Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 10 '24 17:10 vercel[bot]

image

hi @nandanams03, congrats! on your first contribution, unfortunately I can't merge your request because of the following reasons:

  • There are only two fields in the Notion database: Name and Email. The timestamp and ID fields are auto-generated by Notion itself when a new entry is added, which is why I haven't added them.

  • Additionally, the shapes do not match for the API, indicating that the PR may not have been properly tested.

@notionhq/client warn: request fail {
  code: 'validation_error',
  message: 'Email is expected to be title. Name is expected to be rich_text. Timestamp is not a property that exists.'
}
 POST /api/notion 500 in 1129ms

P.S. If you really want to contribute to this repository, update the codebase to use server actions instead!

Best, Lakshay

lakshaybhushan avatar Oct 10 '24 19:10 lakshaybhushan