lagom-samples icon indicating copy to clipboard operation
lagom-samples copied to clipboard

Published 20 hours ago • verified publisher icon lagom

Dev Mode tests

Open TimMoore opened this issue 6 years ago • 3 comments
trafficstars

Currently, the gRPC example projects don't run in dev mode due to https://github.com/lagom/lagom/issues/1857.

It would be nice if we could catch this in CI. I'm opening this issue to start a discussion with the team about how we might be able to do this, and whether it would be worthwhile. I guess we'd need to add scripted tests, which could inflate the build times a lot. Maybe as a nightly job?

TimMoore avatar May 22 '19 02:05 TimMoore

We'd want the scripted tests to roughly mirror the instructions we provide in the read-me files for each example. Otherwise, we would need to manually run through the instructions for QA on any significant change.

TimMoore avatar May 22 '19 02:05 TimMoore

IMHO, this issue surfaces in lagom/lagom-samples but it should be caught in either lagom/lagom or playframework/play-grpc .

ignasi35 avatar May 22 '19 08:05 ignasi35

For the specific gRPC/Akka Discovery problem, I agree, but the reason I raised this issue separately is because some kind of testing of the user experience of the samples would be good to have in general.

TimMoore avatar May 22 '19 08:05 TimMoore