Results 265 comments of Lauris BH

Wasn't there an idea to drop `secrets` section from step? Maybe let's do not add variables section and keep only one way to use them with `from_variable`?

I don't think setting them explicitly is a good idea as that could have unforeseen consequences that would be not so easy to track down both from usability and security...

> > Wasn't there an idea to drop `secrets` section from step? > > I am not aware of it. If it is just an idea without a proper discussion,...

Also would be confusing if both variables and secrets would be used by the same name on what takes preference etc. I only briefly skimmed through file changes but imho...

imho droping `secrets` and having only `from_secret` would make all less complicated 😅

RUN commands should be merged together to minimize layer count

Sure, just added a comment to not forget that

@simcop2387 can you check if #4326 fixes also your use case?

@xoxys Actually I have very similar use case and why I created PR, I have docker runners and one macos local runner that needs to run only specific workflows. Idea...

For now I had no need to use label filters so I may be missing something but can you explain a bit more about broken/useless how?