sealos icon indicating copy to clipboard operation
sealos copied to clipboard

feature: Add SSH option to the scale command(sealos add/delete).

Open lmsh7 opened this issue 2 years ago • 5 comments

  • Added SSH to apply.ScaleArgs, making it possible to specify password and other SSH options when adding nodes, and modified the corresponding test files.
  • Fixed a documentation error that incorrectly stated "addCmd represents the delete command".
  • Added a TODO at a specific location.
  • Added a break statement to GetIPSByRole to prevent unnecessary comparisons.

lmsh7 avatar Apr 01 '23 09:04 lmsh7

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Apr 01 '23 09:04 cla-assistant[bot]

Great job! Please add a test report for this PR.

fanux avatar Apr 01 '23 10:04 fanux

Codecov Report

Patch coverage: 100.00% and project coverage change: +5.98 :tada:

Comparison is base (339adfa) 67.19% compared to head (d21eac3) 73.17%.

:exclamation: Current head d21eac3 differs from pull request most recent head e9f4746. Consider uploading reports for the commit e9f4746 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2896      +/-   ##
==========================================
+ Coverage   67.19%   73.17%   +5.98%     
==========================================
  Files           8        8              
  Lines         567      604      +37     
==========================================
+ Hits          381      442      +61     
+ Misses        153      128      -25     
- Partials       33       34       +1     
Impacted Files Coverage Δ
pkg/apply/args.go 100.00% <100.00%> (ø)
pkg/apply/scale.go 76.59% <100.00%> (+5.08%) :arrow_up:

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 01 '23 15:04 codecov[bot]

Great job! Please add a test report for this PR.

Test report:

  1. Add node with wrong setting. 屏幕截图 2023-04-05 155248
  2. Clusterfile after add failed. 屏幕截图 2023-04-05 153926
  3. Add node with correct ssh setting and build connection successfully. 屏幕截图 2023-04-05 154114

lmsh7 avatar Apr 05 '23 07:04 lmsh7

Maybe you can add more test: create a cluster and add one node with different password and delete one node in the cluster, print the Cluster file and see what will happen.

fix this can merge it .

cuisongliu avatar Apr 28 '23 09:04 cuisongliu

This issue has been automatically closed because we haven't heard back for more than 60 days, please reopen this issue if necessary.

stale[bot] avatar Jun 27 '23 10:06 stale[bot]