l0rinc

[IBD] multi-byte block obfuscation

65

This change is part of [[IBD] - Tracking PR for speeding up Initial Block Download](https://github.com/bitcoin/bitcoin/pull/32043) ### Summary Current block obfuscations are done byte-by-byte, this PR batches them to 64 bit...

coins,refactor: Reduce `getblockstats` RPC UTXO overhead estimation

1

The [`getblockstats` RPC](https://github.com/bitcoin/bitcoin/pull/10757) currently overestimates UTXO overhead by treating the `fCoinBase` bitfield as a separate `bool` in `PER_UTXO_OVERHEAD`. However, `fCoinBase` and `nHeight` are packed into a single 32-bit integer (both...

refactor: cache block[undo] serialized size for consecutive calls

7

`UndoWriteToDisk` and `WriteBlockToDisk` were delegating a subset of their functionality to single-use methods that didn't optimally capture a meaningful chunk of the algorithm, resulting in calculating things twice (serialized size,...

doc: emphasize that `Assume` always evaluates

2

We've been surprised multiple times by `Assume` doing heavy computations in `release`: * https://github.com/bitcoin/bitcoin/issues/31178#issuecomment-2448867990 * https://github.com/bitcoin/bitcoin/pull/31490#discussion_r1887765453 Since `Assume` is a macro, it could have been written differently to avoid parameter...

optimization: buffer reads(23%)/writes(290%) in [undo]block [de]serialization, 6% faster IBD

1

An alternative implementation of https://github.com/bitcoin/bitcoin/pull/31551, where the block is read into memory in chunks, resulting in more modest gains, is slightly more complicated, but uses less memory. --- This is...

coins: warn on shutdown for big UTXO set flushes

3

Split out of https://github.com/bitcoin/bitcoin/pull/30611#issuecomment-2549027130 Setting a large `-dbcache` size postpones the index writes until the coins cache size exceeds the specified limit. This causes the final flush after manual termination...

build: Use character literals for generated headers to avoid narrowing

1

Use character literals instead of integer hex values (i.e. `'\x5b','\x0a', ...` instead of `0x5b, 0x0a, ...`) for generated JSON headers for tests. This avoids C++11 narrowing warnings in a more...

optimization: bulk reads(27%)/writes(290%) in [undo]block [de]serialization, 6% faster IBD

1

An alternative implementation of https://github.com/bitcoin/bitcoin/pull/31539, where the whole block is read into memory instead of doing it in chunks, as suggested by @theuni. ------ This is a follow-up to https://github.com/bitcoin/bitcoin/pull/31490...

Document missing upstream changes

2

These were the ones I found here that aren't present in the official repo, many had PRs there already - revived the ones that don't (had to commit under my...

Clone of https://github.com/google/leveldb/pull/1259 > In case of Bitcoin Core the batch sizes at the final UTXO set are fixed (16 MiB currently). This could enable us [pre-sizing the batch](https://github.com/bitcoin/bitcoin/blob/master/src/txdb.cpp#L94), if...