l0rinc

cmake: Include the *werror_flag in TryAppend*Flags compiler cache

10

Trigger recompilation when `working_linker_werror_flag`or `working_compiler_werror_flag` are changed since it can affect the outcome. See: https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1711409392

test: add a few more base32/64 calculation corner cases

19

Added tests for base32 and base 64 conversions.

doc: Change `nproc` in docs to `getconf _NPROCESSORS_ONLN`

4

Split out of https://github.com/hebasto/bitcoin/pull/316/files#r1711537463 `nproc` is linux only, `getconf _NPROCESSORS_ONLN` is used in the Linux kernel for the same task (works on Mac as well): https://github.com/torvalds/linux/blob/master/tools/testing/selftests/rcutorture/bin/kvm-build.sh#L44 On linux: ``` #...

test: support std::optional in BOOST_CHECK_* and increase FromUserHex fuzz feature coverage

12

Enhanced `FromUserHex` coverage by: * Added `std::optional` support to `BOOST_CHECK_EQUAL`, allowing direct comparisons of `std::optional` with other `T` expected values. * Increased fuzz testing for hex parsing to validate against...

build: replace custom `MAC_OSX` macro with standard `__APPLE__` for consistent macOS detection

13

This PR aims to standardize and simplify macOS-specific checks within our codebase by replacing the custom-defined `MAC_OSX` macro with the universally recognized `__APPLE__`macro. Unlike `MAC_OSX`, which is not predefined and...

test: remove unused src_dir param from run_tests after CMake migration

6

The `src_dir` usage was removed in https://github.com/bitcoin/bitcoin/commit/a8a2e364acf55bbe18404ab21f852d52257bcb6d#diff-437d7f6e9f2229879b60aae574a8217f14c643bbf3cfa9225d8011d6d52df00cL598, making the parameter unused.

refactor: Allow `CScript`'s `operator<<` to accept spans, not just vectors

4

Split out of https://github.com/bitcoin/bitcoin/pull/30377#discussion_r1722326803. Replace `_hex_v_u8` for `CScript` appends to `_hex`, to skip vector conversion before serializing to the `prevector` in `CScript`. To enable both `unsigned char` and `std::byte` values,...

coins: Add move operations to Coin and CCoinsCacheEntry

13

Related to https://github.com/bitcoin/bitcoin/pull/28280#discussion_r1703187118, the CI build had a Sonar warning, namely: > "std::move" should not be called on an object of a type with neither move constructor nor move-assignment operator....

refactor: migrate `bool GetCoin` to return `optional<Coin>`

4

While reviewing [the removal of the unreachable combinations from the Coin cache logic](https://github.com/bitcoin/bitcoin/pull/30673#discussion_r1721727681), we've noticed that the related tests often [reflect impossible states](https://github.com/bitcoin/bitcoin/pull/30673/files#r1740154464). Browsing the Coin cache refactoring history revealed...

build: improve cxx and linker flag caching

3

Migration of https://github.com/hebasto/bitcoin/pull/340 `try_append_cxx_flags` and `try_append_linker_flag` are CMake functions used to test and conditionally apply compiler and linker flags to ensure compatibility with the build environment. Currently the only case...