web-server-chrome icon indicating copy to clipboard operation
web-server-chrome copied to clipboard

Directory Selection Cleared on Restart using Linux for Chromebook

Open ecc521 opened this issue 6 years ago • 6 comments

Typically, this web server will remember the directory being served, and when restarted, will begin serving that directory again. If the directory does not exist, the previous selection will be cleared.

When using this web server to server files inside of Linux for Chromebooks, however, this strategy fails. Opening the server before Linux has opened will result in the previous directory selection being cleared (as the Linux files aren't yet available).

Given that this extension is perhaps the only option for locally serving files on chromebooks (the Linux terminal has it's own 127.0.0.1, and crash doesn't let you do anything significant), it would seem like we should handle this behavior. (Perhaps check if the directory exists every second, and give a warning that the directory doesn't exist?)

ecc521 avatar Oct 14 '19 02:10 ecc521

You're referring to if you select a crostini folder? "Linux Files" in the files pane?

kzahel avatar Oct 19 '19 17:10 kzahel

Correct. If you select a cronsiti folder, and restart, the server remembers the folder you selected (as it should)... but if the server opens before cronsiti does, it errors, and clears your selection.

On Sat, Oct 19, 2019, 1:11 PM Kyle Graehl [email protected] wrote:

You're referring to if you select a crostini folder? "Linux Files" in the files pane?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kzahel/web-server-chrome/issues/192?email_source=notifications&email_token=AKDVOG3DNUFM24O73HZYIPLQPM5UNA5CNFSM4JAJYRVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBXXA2I#issuecomment-544174185, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDVOG2QSN6VN5K4YNNVIDTQPM5UNANCNFSM4JAJYRVA .

ecc521 avatar Oct 19 '19 18:10 ecc521

That's annoying. I don't think I can address it though.

kzahel avatar Jan 27 '21 04:01 kzahel

Not sure - is there a reason the webserver needs to clear the selection if it doesn't exist? Could it simply ask for a new selection (without clearing the invalid one), while polling every few seconds to see if the directory appeared (and the selection became valid)?

Probably only needs to run for a minute or so due to startup.

At the moment, I don't care a whole lot about that issue, but I'm not sure it should be closed.

ecc521 avatar Jan 27 '21 12:01 ecc521

Sure, sorry I went on a close spree yesterday. Thanks for commenting. I'm not sure I'll do any more updates to this project though since chrome apps are deprecated and probably in a year or two chrome apps will just disappear. (not actually certain if they'll continue to exist for chromeOs at least for a number of years?)

kzahel avatar Jan 27 '21 19:01 kzahel

I can certainly understand closing sprees, so no problem there. I no longer have a significant interest in ChromeOS at the moment, as everything is at home now, and if chrome apps are being killed, I'm not sure there's any reason to fix this issue (that said, I still think it should stay open - it's a known, fixable, bug)

If things do change, I might take a look at this again. As is, I'd say it's a 'wontfix' if anything.

On Wed, Jan 27, 2021, 2:18 PM Kyle Graehl [email protected] wrote:

Sure, sorry I went on a close spree yesterday. Thanks for commenting. I'm not sure I'll do any more updates to this project though since chrome apps are deprecated and probably in a year or two chrome apps will just disappear. (not actually certain if they'll continue to exist for chromeOs at least for a number of years?)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kzahel/web-server-chrome/issues/192#issuecomment-768515778, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDVOG45FOCLQNFTOAZTLSTS4BRIJANCNFSM4JAJYRVA .

ecc521 avatar Jan 27 '21 20:01 ecc521