image-compare-viewer icon indicating copy to clipboard operation
image-compare-viewer copied to clipboard

There is a bug in script version 1.6.2

Open sergeydemin30111997 opened this issue 2 years ago • 7 comments
trafficstars

In version 1.6.2 there is a bug that can only be reproduced on the iPhone in the Safari browser. Its essence is that when we try to move the bar before/after, our page moves to the top. Everything is fine in version 1.5.0

sergeydemin30111997 avatar Nov 24 '23 13:11 sergeydemin30111997

I'm also having this issue. I'm using the viewer on a SvelteKit app.

nnrahm avatar Nov 28 '23 19:11 nnrahm

I think is due the update of the body-scroll-lock dependency.

It appears that it changes how it works for iOs from one version to another

You can look it here: https://github.com/willmcpo/body-scroll-lock/releases/tag/v4.0.0-beta.0

Maybe downgrade the dependency just one version till the v4.0.0 is no longer beta can be a solution.

image

I can confirm this issue on apple devices. I had to revert to 1.5 version.

TheFienix avatar Jan 10 '24 11:01 TheFienix

I'm also having this issue in all browsers on ios (iphone/ipad). when I try to move the bar before/after the page refreshes

ahmed-mera avatar Jan 19 '24 21:01 ahmed-mera

Body Scroll Lock project seems abandoned.

However, we might have a way to make it work with iOS, if you check this guy: https://github.com/rick-liruixin/body-scroll-lock-upgrade

npm i body-scroll-lock-upgrade

4wk- avatar Jan 30 '24 14:01 4wk-

Body Scroll Lock project seems abandoned.

However, we might have a way to make it work with iOS, if you check this guy: https://github.com/rick-liruixin/body-scroll-lock-upgrade

npm i body-scroll-lock-upgrade

I'm using plain HTML and JavaScript, how can I call body-scroll-lock? Does ImageCompare library support event listeners?

nguyenhc-bitvn avatar Mar 15 '24 04:03 nguyenhc-bitvn