Kyle Fuller
Kyle Fuller
I think I agree with 2, perhaps it would make sense to vendor swiftenv into the build pack itself. Then there is no need to download it (either via git...
What are the steps to reproduce this crash? / what is the input JSON Schema and JSON structure?
Do you have a JSON schema and JSON structure inputs which can be used to reproduce the mentioned problem? Is this reliably crashing?
> I'm debating if we should make the date-time format use the underlying date and time validators internally so that we can be sure that they are absolutely identical in...
After giving more thought to this, in date-time we will need to parse both the date and time, not just validate the date and time separately, but also enforce further...
Ran out of time for now, but made an attempt at regex time validation, missing the leap second checks but there as comments in https://github.com/kylef/JSONSchema.swift/commit/12bbf6d0ffd1d50e9d39527e30952647f0817bd0 in the time branch. Not...
> 1. We are using jnewc's branch for an EU-wide project at the moment, and it works perfectly. Merging this PR would fix the current issue with master not allowing...
@jnewc I've merged in the date parser (pretty must as-is) via 9b9dc51fb67d1611401f209ba2558501b044971d, I've extended the test suite in https://github.com/json-schema-org/JSON-Schema-Test-Suite/pull/483 to contain all the month-day limit validations which should test regex...
Based on https://github.com/kylef/JSONSchema.swift/pull/118#discussion_r616868457 and https://github.com/kylef/JSONSchema.swift/pull/118#discussion_r619520670, I'd suggest that the file should exist in the `Sources/Format` directory.
I'm not sure that the formats used here for date-time, date, time match what is specified in the relevant specifications. Could you please enable the tests for these formats so...