geo-index icon indicating copy to clipboard operation
geo-index copied to clipboard

Python: impl FromPyObject for reliable FFI

Open kylebarron opened this issue 1 year ago • 2 comments

I feel like I'd want to expose the buffer protocol on our classes, so that we could call memoryview on any user input and interpret it the same whether it's one of our classes or a plain bytes object. In this case, we might also want to move to top-level functions instead of class methods?

kylebarron avatar Apr 01 '24 04:04 kylebarron

We should check if py.extract<Vec<u8>> works

kylebarron avatar Jul 22 '24 18:07 kylebarron

We should probably implement FromPyObject on the main index class, but also potentially have a separate "view" class, not exported to Python, so that we can use a python buffer without copying it

kylebarron avatar Jul 22 '24 18:07 kylebarron

Closed by #55

kylebarron avatar Aug 27 '24 18:08 kylebarron