Kyle Hayes

I am trying to run the approval workflow to see if this passes the base tests. Sorry for the delay in response here. Are you OK with licensing this with...

BTW, data types like BOOL and SINT/USINT are single bytes.

Looks like all the base checks passed. I will move this over to the prerelease branch because I merge all changes there first, update the version and then merge over...

I did a check of the code. I like most of it, thanks! On the padding, I think I might want to do a slightly different direction. Rather than specifically...

Oops, I was looking at the wrong spot in GitHub, you've already PRed this for the prerelease branch. Sorry!

I move the base branch to omron_updates. This branch is forked off of prerelease.

The latest looks really good. Thanks for that! The only potential problem I see is when the padding is added, there is no check to make sure we are not...

I found this about Omron: - Omron’s NJ structure types use the natural alignment of their members, up to 64-bit, then pad the structure to the largest alignment of it...

Let's just give this a try. We can go around in circles, but if all the checks pass against my various PLCs and against your Omron, that should be good...

I think @ptsOSL's PR is going to fix this. If not, it will at least be a better base to start from.