OJ Kwon

Results 264 comments of OJ Kwon

It is extremely hard to track machine translated contents as placeholder to actual translated contents and most cases I haven't seen those process speeds up translation but just causes more...

You may refer https://chromium.googlesource.com/chromium/deps/hunspell_dictionaries/+/master for source of available dictionary list - there aren't those dict available plus hunspell doesn't support CN (https://github.com/hunspell/hunspell/issues/502) as well.

**disclaimer: I am author of listed modules below.** To resolve issues listed around, I have wrote https://github.com/kwonoj/cld3-asm / https://github.com/kwonoj/electron-hunspell (and https://github.com/kwonoj/hunspell-dict-downloader as bonus module) This separated module resolves each feature...

I think we need an example input file can reproduce. Or is it occurs on any source as an input?

> heap_get_oob this issue is a separate one, upstream issue filed at https://github.com/swc-project/swc/issues/5406

Mind elaborate what this PR exactly does? description / test cases?

I'd be hesitant to review PR without having any proper description or test cases to explain what it does exactly.

> This PR lets users to use module: 'esm' option to emit top level import and its reference instead of require() calls. The reason I asked for test case is...

Thanks for the clarification. This helps a lot. Random thought: what if we honor `swcrc`'s `module.type` config instead of plugin specifies duplicated option for it again? say, like ``` //.swcrc...

> What were the previous opinions from the team about exposing the whole swcrc to plugins? It was not included as there was no concrete use case for the first...